Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix early stopping off by 2 (min_epochs) #617

Merged
merged 2 commits into from
Dec 9, 2019
Merged

Fix early stopping off by 2 (min_epochs) #617

merged 2 commits into from
Dec 9, 2019

Conversation

awaelchli
Copy link
Contributor

@awaelchli awaelchli commented Dec 9, 2019 •
edited
Loading

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos, doc improvements)
  • Did you read the contributor guideline?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

What does this PR do?

Fixes #606.

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@awaelchli awaelchli changed the title Fix early stopping Fix early stopping off by 2 (min_epochs) Dec 9, 2019
@williamFalcon williamFalcon merged commit e2ee4dd into Lightning-AI:master Dec 9, 2019
@awaelchli awaelchli deleted the fix-early-stopping branch March 7, 2020 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Early Stopping kicks in at min_epochs + 2 instead of min_epochs
2 participants
@awaelchli @williamFalcon